Skip to content

refactory test and move logic to model - partner user invite service - #3048

Merged
edwinthinks merged 2 commits into
rubyforgood:mainfrom
italomatos:move-invite-partner-user-logic-to-service
Jul 26, 2022
Merged

edwinthinks merged 2 commits into
rubyforgood:mainfrom
italomatos:move-invite-partner-user-logic-to-service

Conversation

@italomatos

@italomatos italomatos commented Jul 23, 2022 •

Copy link
Copy Markdown
Contributor

Description

This PR has a goal to move partner user invite logic from controller to new service, and improve test coverage.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • login as Organization Admin
  • go to partner detail page
  • click on "Add user to partner" button

Screenshots

#Before refactory
image

#After refactory
image

@italomatos
italomatos force-pushed the move-invite-partner-user-logic-to-service branch 3 times, most recently from 0e5de0a to e388f80 Compare July 24, 2022 02:04
Comment thread spec/requests/partners_requests_spec.rb Resolved
Comment thread spec/requests/partners_requests_spec.rb Resolved
@italomatos
italomatos force-pushed the move-invite-partner-user-logic-to-service branch 2 times, most recently from 19c9e6a to fe65cea Compare July 24, 2022 13:37
@italomatos
italomatos requested a review from edwinthinks July 24, 2022 18:11
@italomatos
italomatos force-pushed the move-invite-partner-user-logic-to-service branch from fe65cea to 24b11ab Compare July 24, 2022 21:36
@italomatos
italomatos force-pushed the move-invite-partner-user-logic-to-service branch from 24b11ab to d87aaf0 Compare July 24, 2022 22:51
@edwinthinks
edwinthinks merged commit b93dd1b into rubyforgood:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants